Skip to content

Update dependencies #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2017
Merged

Update dependencies #1098

merged 1 commit into from
Jan 12, 2017

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Jan 7, 2017

@yorkie
Copy link
Contributor

yorkie commented Jan 7, 2017

@lpinca html-to-text is a semver-major upgrade, a simple description about why we need this patch and risks?

@lpinca
Copy link
Member Author

lpinca commented Jan 7, 2017

@yorkie AFAIK the only breaking change there is the switch to htmlparser2. It should have no side effects for us.

@lpinca
Copy link
Member Author

lpinca commented Jan 7, 2017

html-to-text is only used in the event-geo.js script to have a "text" description of the events in the map of the events page.

ryanmurakami
ryanmurakami approved these changes Jan 11, 2017
View reviewed changes
Copy link
Contributor

@ryanmurakami ryanmurakami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipj phillipj merged commit ba7b2e2 into master Jan 12, 2017
@phillipj phillipj deleted the update/dependencies branch January 12, 2017 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ryanmurakami ryanmurakami ryanmurakami approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lpinca @yorkie @ryanmurakami @phillipj